Skip to content

Conversation

@TalzelAti
Copy link
Contributor

No description provided.

… this needs to be modified manually for various fixes
dash (-) symbols are not allowed in template keys
…m file

used null resource with remote-provisioner, that starts running only after volume attachments and public ip assignment to the machine
it is executed before mounting and pulling provisioner
1. 'container' returns now a fresh name instead of boolean
2. no boolean output in deplyomentM scripts
1. added placeholders
2. removed useless duplicate type synonym
Copy link
Contributor

@lachrimae lachrimae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good. I have left comments on a handful of extremely minor formatting problems.

@TalzelAti TalzelAti merged commit d1d7b6f into master Jan 14, 2020
@TalzelAti TalzelAti deleted the deployment branch January 14, 2020 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants